nixos/users-groups: split isSystemUser/isNormalUser and uid check into two #357944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
SuperSandro2000
changed the title
…o two Before the error message only mentioned isSystemUser/isNormalUser which lead to a confusing situation when setting isNormalUser and an uid like 500 which would generate an error like: error: Failed assertions: - Exactly one of users.users.other.isSystemUser and users.users.other.isNormalUser must be set. from which you cannot know that setting the uid to 500 *and* setting isNormalUser is the actual problem. With this patch the error looks like: error: Failed assertions: - A user cannot have a users.users.fixme.uid set below 1000 and set users.users.fixme.isNormalUser. Either users.users.fixme.isSystemUser must be set to true instead of users.users.fixme.isNormalUser or users.users.fixme.uid must be changed to 1000 or above.
SuperSandro2000
force-pushed
the
users-missleading
branch
from
f20ab63 to
db0a0b1
Compare
|
I just tested this, and it works as intended, however, shouldn't we also include such assertions for This is the cases I ran. users.users.testing = {
group = "testing";
# fails - good
# isNormalUser = true;
# uid = 100;
# passes - good
# isNormalUser = true;
# uid = 1000;
# fails - good
# isNormalUser = true;
# isSystemUser = true;
# uid = 1000;
# passes - should fail????
# isSystemUser = true;
# uid = 1001;
};
users.groups.testing = {}; |
ofborg
bot
added
10.rebuild-darwin: 0
|
@eyJhb did that fail before? If not I would like to move that to a 2nd PR otherwise I get a knot in my head fixing this. |
|
@SuperSandro2000 no it did not, so I think you should be good to go, and it could be a separate PR. |
eyJhb
approved these changes
Dec 17, 2024
wegank
added
the
12.approvals: 1
|
I've used this cherry-picked in my fork since creating this PR and didn't encounter any issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the error message only mentioned isSystemUser/isNormalUser which
lead to a confusing situation when setting isNormalUser and an uid like
500 which would generate an error like:
error:
Failed assertions:
from which you cannot know that setting the uid to 500 and setting
isNormalUser is the actual problem.
With this patch the error looks like:
error:
Failed assertions:
Either users.users.fixme.isSystemUser must be set to true instead of users.users.fixme.isNormalUser
or users.users.fixme.uid must be changed to 1000 or above.
I tested this via the config where I before ran into this error and it now produced a better error message and none after fixing it like before.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.